Simplify the xcb tray window logic and avoid SNI transitional flicker between two UI #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… between two UI Right now both virtual keyboard and classicui want SNI. When transition between two UI, sni is disabled and then re-enabled which is causing XCB tray window being show/hide immediately. This change try to simplify the xcb tray window logic: 1. hide, if suspend() 2. If SNI addon is not available. show on resume If SNI addon is available, defer 1sec and check SNI status. SNI enable/disable logic is updated to allow multiple enable/disable by using a reference counter. disable() is deferred with event dispatcher, to avoid enable/disable causing register/unregistration.
600a5d2 to
4694a25
Compare
Contributor
|
@wengxt 如果有连续disable的话，则会向消息循环发送多个事件。这个可以优化一下 |
Member
Author
不太重要，而且改成引用计数就需要多次 |
Contributor
|
fcitx5启动，默认使用了classic ui,此时enable sni; 目前的逻辑没办法规避这一点吧 |
Contributor
导致托盘图标退了一下又重新出现 怪难接受的 |
Member
Author
|
@hantengc 可以，因为disable延迟到event loop下一个处理了 现在第二个enable会在之前的disable起作用前执行 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now both virtual keyboard & classicui want SNI, but when transition
between two UI, sni is disabled and then re-enabled which is causing XCB
tray window being show/hide immediately.
This change try to simplify the xcb tray window logic:
If SNI addon is available, defer 1sec and check SNI status.
SNI enable/disable logic is updated to allow multiple enable/disable by
using a reference counter. disable() is deferred with event dispatcher,
to avoid enable/disable causing register/unregistration.