fix(flutter_bloc): rebuild BlocSelector when selector changes
#4415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure BlocSelector rebuilds correctly when selector function is updated. Closes felangel#4414
7 tasks
BlocSelector when selector changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4415 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 1635 1637 +2
=========================================
+ Hits 1635 1637 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felangel
approved these changes
May 2, 2025
BlocSelector when selector changesBlocSelector when selector changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure BlocSelector rebuilds correctly when selector function is updated. Closes #4414
Status
READY
Breaking Changes
NO
Description
This PR addresses an issue in the BlocSelector widget where a rebuild was not triggered when the selector function itself changed. The fix ensures that when the selector function is updated, the widget will rebuild to reflect the new selector logic. This change improves the behavior of the BlocSelector widget, making it more reliable when used with dynamic selector functions.
Type of Change