Skip to content

fix(flutter_bloc): BlocProvider explicit lazy to support avoid_redundant_argument_values #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2021
Merged

fix(flutter_bloc): BlocProvider explicit lazy to support avoid_redundant_argument_values #2917

merged 1 commit into from
Nov 3, 2021

Conversation

@felangel
Copy link
Owner

@felangel felangel commented Nov 3, 2021 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

Screen Shot 2021-11-03 at 2 41 36 PM

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package labels Nov 3, 2021
@felangel felangel added this to the v7.x.x milestone Nov 3, 2021
@felangel felangel self-assigned this Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #2917 (fd461aa) into master (f363571) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #2917    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           25         9    -16     
  Lines          692       172   -520     
==========================================
- Hits           692       172   -520
Impacted Files Coverage Δ
packages/flutter_bloc/lib/src/bloc_provider.dart 100.00% <100.00%> (ø)
packages/bloc_concurrency/lib/src/sequential.dart
packages/bloc_concurrency/lib/src/restartable.dart
packages/bloc_test/lib/src/mock_bloc.dart
packages/bloc_concurrency/lib/src/concurrent.dart
packages/bloc/lib/src/bloc.dart
packages/replay_bloc/lib/src/replay_cubit.dart
packages/replay_bloc/lib/src/replay_bloc.dart
...ackages/hydrated_bloc/lib/src/hydrated_cipher.dart
packages/bloc_test/lib/src/when_listen.dart
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ae554...fd461aa. Read the comment docs.

@felangel felangel removed this from the v7.x.x milestone Nov 3, 2021
marcossevilla
marcossevilla approved these changes Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felangel felangel merged commit 14b6802 into master Nov 3, 2021
@felangel felangel deleted the fix/bloc-provider-explicit-lazy branch November 3, 2021 20:19
Gene-Dana
Gene-Dana reviewed Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@Gene-Dana Gene-Dana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Looks great !

Gene-Dana
Gene-Dana reviewed Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@Gene-Dana Gene-Dana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gene-Dana Gene-Dana Gene-Dana left review comments

@marcossevilla marcossevilla marcossevilla approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

@jeroen-meijer jeroen-meijer Awaiting requested review from jeroen-meijer

@jolexxa jolexxa Awaiting requested review from jolexxa

Assignees

@felangel felangel

Labels

bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: warning when setting lazy: true

3 participants

@felangel @marcossevilla @Gene-Dana