Codecov Report

Merging #344 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #344   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         164    181   +17     
=====================================
+ Hits          164    181   +17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a804b...5380896. Read the comment docs.

Hi, in case I want to access Bloc via BlocProvider but don't want to dispose Bloc on @override dispose() of Widget, is it possible?

@anticafe can you provide your use-case? With these changes our intention is to highly recommend creating/providing a bloc using the BlocProvider.

With this change, if I still need a stateful widget can I create my blocs in the initState like I use to, or does all bloc creation have to use this new BlocProvider format?

@warriorCoder with this change you will no longer need to make StatefulWidgets to init and dispose your bloc. I'm still working out a couple of edge cases but hopefully this can be released with flutter_bloc 0.16.0 within the next week.

@anticafe #347 should address your concerns 👍

Hi @felangel I don't remember the reason correctly but in my own project, I don't dispose Bloc until the MyApp.dispose() is called. It seems if dispose a Bloc then next time enter this screen again, I cannot re-initialize it.

@anticafe I have updated all of the docs/tutorials to use the new BlocProvider introduced in flutter_bloc v0.16.0. Let me know if you have any additional questions but you should have full control over when the blocs are disposed and no longer need to create your own StatefulWidget.

Hello @felangel ,

i have tried to update my project to the newest flutter_bloc version 16.0. I made all changed that are required, but now my App crashes when i try to access the Blocs within a ```BlocListenerTree``.

Error Message:

 BlocProvider.of() called with a context that does not contain a Bloc of type
I/flutter (14227):         `MyBloc.

App Architecture:

MyApp extends StatefulWidget{
  State<StatefulWidget> createState() => MyAppState();
}

class MyAppState extends State<MyApp> {
 @override
  Widget build(BuildContext context) {
    return BlocProviderTree(
      blocProviders: [
        BlocProvider<BlocA>(
          builder: (BuildContext context) =>
              BlocA(new FirestoreProvider()),
          dispose: (BuildContext context, BlocA bloc) => bloc.dispose(),
        ),
        BlocProvider<BlocB>(
          builder: (BuildContext context) =>
              GroupBloc(new FirestoreProvider(), new CloudProvider()),
          dispose: (BuildContext context, BlocB bloc) => bloc.dispose(),
        ),
      ],
      child: BlocListenerTree(
        blocListeners: [
          BlocListener<BlocAEvent, BlocAState>(
            bloc: BlocProvider.of<BlocA>(context),
            listener: (BuildContext context, BlocAState state) {
             // Do sth.
            },
          ),
          BlocListener<BlocBEvent, BlocBState>(
            bloc: BlocProvider.of<BlocB>(context),
            listener: (BuildContext context, BlocBStatestate) {
                 // Do sth.
              };
            },
          ),
        ],
        child: BlocBuilder(
          bloc: BlocProvider.of<BlocB>(context),
          builder: (BuildContext context, BlocBState state) {
            return new MaterialApp(
              theme: state.theme,
              debugShowCheckedModeBanner: BuildMode().isDebugMode,
              title: 'MyApp',
              home: new MainPage(),
            );
          },
        ),
      ),
    );
  }
}

This worked fine until version 16.0, so is this not longer supported or is this one of the edge cases where are you working on?

King regards

Max

Hi @Knupper 👋

You need to move the BlocProvider to the parent of the widget where you will be using the bloc.
In this case you can do something like:

void main() {
  runApp(
    BlocProviderTree(
      blocProviders: [
        BlocProvider<BlocA>(
          builder: (BuildContext context) =>
              BlocA(FirestoreProvider()),
          dispose: (BuildContext context, BlocA bloc) => bloc.dispose(),
        ),
        BlocProvider<BlocB>(
          builder: (BuildContext context) =>
              GroupBloc(FirestoreProvider(), CloudProvider()),
          dispose: (BuildContext context, BlocB bloc) => bloc.dispose(),
        ),
      ],
      child: MyApp(),
    ),
  );
}

Then you can refactor MyApp to just be a StatelessWidget like:

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return BlocListenerTree(
      blocListeners: [
        BlocListener<BlocAEvent, BlocAState>(
          bloc: BlocProvider.of<BlocA>(context),
          listener: (BuildContext context, BlocAState state) {
            // Do sth.
          },
        ),
        BlocListener<BlocBEvent, BlocBState>(
          bloc: BlocProvider.of<BlocB>(context),
          listener: (BuildContext context, BlocBStatestate) {
            // Do sth.
          },
        ),
      ],
      child: BlocBuilder(
        bloc: BlocProvider.of<BlocB>(context),
        builder: (BuildContext context, BlocBState state) {
          return MaterialApp(
            theme: state.theme,
            debugShowCheckedModeBanner: BuildMode().isDebugMode,
            title: 'MyApp',
            home: MainPage(),
          );
        },
      ),
    );
  }
}

Hope that helps 👍

Thank you for your reply @felangel . This was my workaround, but i was not sure if this is the best solution for it.

Keep going with the plugin, it helps me a lot with a good architecture. :)