Skip to content

Commit 1b28e07

Browse files
committed
fix(element-viewer): ensure image is removed from shadow DOM on disconnect
1 parent 1ce2dca commit 1b28e07

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

‎packages/element-viewer/src/index.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export default class CropperViewer extends CropperElement {
128128
}
129129

130130
protected disconnectedCallback(): void {
131-
const { $selection, $sourceImage } = this;
131+
const { $image, $selection, $sourceImage } = this;
132132

133133
if ($selection && this.$onSelectionChange) {
134134
off($selection, EVENT_CHANGE, this.$onSelectionChange);
@@ -145,6 +145,12 @@ export default class CropperViewer extends CropperElement {
145145
this.$onSourceImageTransform = null;
146146
}
147147

148+
const shadow = this.$getShadowRoot();
149+
150+
if ($image && shadow?.contains($image)) {
151+
shadow.removeChild($image);
152+
}
153+
148154
super.disconnectedCallback();
149155
}
150156

0 commit comments

Comments
 (0)