What was the reason behind simplifying go linter? #5568
Closed
dormant-user
started this conversation in
General
Replies: 1 comment 2 replies
-
|
Lots of the "errors" you mention were actually originally ignored because they were marked with nolint. See 23c4e45. I re-added gocritic, govet and revive. I decided to simplify it just to make it more streamlined with other packages use, and to reduce the maintenance. I'm happy using golanglint-ci's defaults, instead of manually enabling a dozen linters and having to maintain that list with a lot of options I don't know about. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The commit 9d44932, significantly simplified the backend linter. When I switch to the older
.golangci.yml, with the current codebase, I see the following issues. Some of them seem pretty reasonable to me. I'm trying to understand why it was changed.Beta Was this translation helpful? Give feedback.
All reactions