Add validation for an attempted exclusion addition #4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e8dbf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4688 +/- ##
===========================================
- Coverage 47.26% 2.48% -44.78%
===========================================
Files 2547 2545 -2
Lines 465051 465385 +334
Branches 19744 3525 -16219
===========================================
- Hits 219791 11551 -208240
- Misses 244782 451939 +207157
- Partials 478 1895 +1417
🚀 New features to boost your workflow:
|
MauricioUyaguari
approved these changes
Dec 4, 2025
| .currentProjectConfiguration; | ||
| try { | ||
| if (currentConfiguration.projectDependencies.length) { | ||
| this.editorStore.projectConfigurationEditorState.syncExclusionsToProjectDependencies(); |
Member
There was a problem hiding this comment.
this shouldnt be needed if the mobox is done correctly. why do we need to sync. the observables should handle the updates.
| ProjectVersionEntities.serialization.fromJson(e), | ||
| ); | ||
|
|
||
| const exclusionsByParent = new Map<string, Set<string>>(); |
Member
There was a problem hiding this comment.
are we removing this logic ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?