[Merged by Bors] - feat: add new item throw behaviors. #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functionality to the current item selection. Convert the PlayerEvent enum into a struct with systems for use in Commands. This replaces the handle_player_events system because of timing issues.
based on negative or positive y throw velocity. Also fix a small comment typo due to the new PlayerEvent & a couple of clippy warnings.
c66d830 to
7154af4
Compare
zicklag
approved these changes
Feb 25, 2023
Member
zicklag
left a comment
There was a problem hiding this comment.
Great job on this, and you got more deletions than you have additions! 🎉
bors merge
bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
Add differing throw types and add their functionality to the current item selection. Convert the PlayerEvent enum into a struct with systems for use in Commands. This replaces the handle_player_events system because of timing issues. Closes: #628 Co-authored-by: Zicklag <zicklag@katharostech.com>
0f51f5f to
3a76520
Compare
Contributor
|
Canceled. |
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
Add differing throw types and add their functionality to the current item selection. Convert the PlayerEvent enum into a struct with systems for use in Commands. This replaces the handle_player_events system because of timing issues. Closes: #628 Co-authored-by: Zicklag <zicklag@katharostech.com>
Contributor
|
Build failed: |
3a76520 to
f588010
Compare
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
Add differing throw types and add their functionality to the current item selection. Convert the PlayerEvent enum into a struct with systems for use in Commands. This replaces the handle_player_events system because of timing issues. Closes: #628 Co-authored-by: Zicklag <zicklag@katharostech.com>
f588010 to
a33f32d
Compare
Contributor
|
Canceled. |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2023
Add differing throw types and add their functionality to the current item selection. Convert the PlayerEvent enum into a struct with systems for use in Commands. This replaces the handle_player_events system because of timing issues. Closes: #628 Co-authored-by: Zicklag <zicklag@katharostech.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add differing throw types and add their functionality to the
current item selection.
Convert the PlayerEvent enum into a struct with systems for use in
Commands. This replaces the handle_player_events system because of
timing issues.
Closes: #628