fix: implement kill callback for all rendered elements #777
Conversation
…om ulid; crab updated to use Spawner component;
|
Yeah, I'm thinking maybe we don't need the The fish school could easily replace it's vector of fish with the entities from the spawner with no negative side-effects, and then we'd no longer have anything using the What do you think? |
I completely agree. It's a nice custom feature to have, but if nothing is using it then we're just going to end up maintaining this feature through future maintenance and functionality, maybe even having to put in workarounds, just for this unused feature to exist. I'll refactor this branch to include the fish school's fish and then remove the |
|
Sounds like a plan! |
…sh school logic to use the new Spawner component to handle killing the fish;
zicklag
left a comment
There was a problem hiding this comment.
Looks good to me, is this ready?
|
Yeah, this is good for now. The rendered players still don't get removed yet, but that's something that might be a little bigger and different from this PR. I'll tackle that one next. |
All elements that act as a spawner (except for the fish school since the spawner acts as the parent element holding the inner fish elements) now have a Spawner component that will be discovered during the "delete element" process.
I also updated the ElementKillCallback ulid string since I just created it manually in the previous ticket and only recently learned of a way to generate a true random ulid string.
We should consider refactoring the fish school spawner to properly behave like a spawner containing entities.