Skip to content

Update publisher image to nodejs22 #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2025
Merged

Update publisher image to nodejs22 #1760

merged 4 commits into from
Nov 4, 2025
+5 −10

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Nov 4, 2025 •
edited
Loading

Updates publisher image so we use nodejs22. The previous nodejs20 image we were using were too old, and rolldown (required for new package tooling tsdown) wasn't being installed.

This PR also reverts #1759 which was the wrong fix.

taeold added 3 commits November 4, 2025 11:29
@taeold
Update publisher image to nodejs22.
999b0ea 
Updates publisher image so we use nodejs22. The previous nodejs20 image we were using were too old, and rolldown (required for new package tooling tsdown) wasn't able to be installed.
@taeold
Merge remote-tracking branch 'origin/master' into fix/update-builder
86d856b
@taeold
remove optional dep requirement.
c54af5f
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 4, 2025

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the foundational Node.js runtime for the publishing process. By moving to Node.js 22, it resolves compatibility issues that prevented the installation of essential modern package tooling, specifically rolldown, thereby ensuring the build and publishing pipeline remains robust and up-to-date.

Highlights

  • Node.js Version Upgrade: The publisher container's base image has been upgraded from Node.js 20 to Node.js 22 to ensure compatibility with modern tooling like rolldown.
  • Dependency Resolution Fix: The package-lock.json file was updated to remove an outdated optional dependency for @rolldown/binding-linux-x64-gnu and adjust a dependency entry, resolving installation issues encountered with the previous Node.js version.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/test.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the publisher container's base image from Node.js 20 to Node.js 22 to support newer tooling. The change is straightforward. I've added one suggestion to pin the Node.js version in the Dockerfile to a specific version to improve build reproducibility.

@taeold taeold enabled auto-merge November 4, 2025 19:38
@taeold taeold added this pull request to the merge queue Nov 4, 2025
Merged via the queue into master with commit ae70695 Nov 4, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhuleatt jhuleatt jhuleatt approved these changes

@brittanycho brittanycho Awaiting requested review from brittanycho

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taeold @jhuleatt