Fixed an issue where firestore:delete would not use the emulator when it should
#6772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6772 +/- ##
==========================================
- Coverage 54.32% 54.31% -0.01%
==========================================
Files 350 350
Lines 24288 24296 +8
Branches 5021 5028 +7
==========================================
+ Hits 13194 13196 +2
- Misses 9888 9894 +6
Partials 1206 1206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rwhogg
reviewed
Feb 14, 2024
rwhogg
reviewed
Feb 14, 2024
rwhogg
reviewed
Feb 14, 2024
rwhogg
reviewed
Feb 14, 2024
…ls into jh-firestore-right
rwhogg
approved these changes
Feb 14, 2024
|
Thanks for PR team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where
firestore:deletewould not use the emulator whenFIRESTORE_EMULATOR_HOSTwas setFixes #6537