Skip to content

fix globbing issue for Hosting #7382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2024
Merged

fix globbing issue for Hosting #7382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b459445
fix globbing issue for Hosting
bkendall Jun 25, 2024
8a77bf9
Merge branch 'master' into bk-fix-glob
bkendall Jun 25, 2024
774858b
Merge branch 'master' into bk-fix-glob
bkendall Jun 25, 2024
50c686a
Merge branch 'master' into bk-fix-glob
bkendall Jun 25, 2024
fa8a669
Merge branch 'master' into bk-fix-glob
bkendall Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Moved `dataconnect.location` key in `firebase.json` to `dataconnect.yaml`.
- Fixes issue where files were not properly being discovered and deployed to Firebase Hosting (#7363, #7378)
1 change: 1 addition & 0 deletions src/listFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ export function listFiles(cwd: string, ignore: string[] = []): string[] {
follow: true,
ignore: ["**/firebase-debug.log", "**/firebase-debug.*.log", ".firebase/*"].concat(ignore),
nodir: true,
posix: true,
});
}