Skip to content

Respect --force during deploy --only storage #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

Respect --force during deploy --only storage #7503

merged 2 commits into from
Jul 30, 2024

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented Jul 29, 2024

Description

Automatically accept prompts during firebase deploy --force --only storage. Fixes #7499

@joehan joehan requested a review from aalej July 29, 2024 18:49
aalej
aalej approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@aalej aalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested using test case in #7499. Good catch updating the other prompt!

@joehan joehan enabled auto-merge (squash) July 30, 2024 16:41
@joehan joehan merged commit 226111b into master Jul 30, 2024
@joehan joehan deleted the jh-respect-force branch July 30, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aalej aalej aalej approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--force does not apply to firebase deploy --only storage, so programmatically provision are not possible

2 participants

@joehan @aalej