Skip to content

Conversation

@joehan
Copy link
Contributor

@joehan joehan commented Jun 3, 2025

Description

Fixes #6753 and also adds database option to MCP tools.

It looks like we previously intentionally omitted the database option for tools - was it because of this issue, or were there other problems that we ran into?

@fredzqm
Copy link
Contributor

fredzqm commented Jun 3, 2025

Code LG.

@tammam-g was working on the exact same code path.

It's probably a good idea to wait for #8700 to be merged first.

@joehan joehan enabled auto-merge (squash) June 4, 2025 18:57
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joehan joehan merged commit 424c548 into master Jun 4, 2025
48 of 50 checks passed
@joehan joehan deleted the jh-db branch June 4, 2025 19:46
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

firestore:delete with database errors

2 participants