Fix ext:configure not settings params without a default #8814
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical bug in the ext:configure command that prevented the proper configuration of extension parameters lacking predefined default values. The fix involves a subtle but important correction in a conditional statement, ensuring that parameter values are correctly applied during configuration.
Highlights
- Bug Fix:
ext:configureparameter setting: I've addressed an issue where theext:configurecommand was unable to correctly set parameters that did not have a default value. This was specifically observed when attempting to set v2 function memory. - Code Correction: Assignment vs. Comparison: In
src/extensions/paramHelper.ts, I've corrected a logical error where an assignment operator (=) was mistakenly used instead of a strict equality operator (===) within anifcondition. This fix ensures that thefirebaseextensions.v1beta.function/locationparameter is correctly identified and its default value updated whenLOCATIONis present innewDefaults.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in ext:configure where params without default values could not be set, due to an assignment operator being used instead of a comparison operator. A suggestion has been made to improve maintainability by extracting a magic string into a constant.
Description
Fixes #8810
Scenarios Tested
Used https://github.com/aalej/issues-8810# to confirm that we can successfully set v2 function memory.