Fixed an issue where the FDC emulator did not have ADC provided #8820
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical issue where the Data Connect (FDC) emulator was not being provided with Application Default Credentials (ADC). The fix ensures that the emulator correctly receives these credentials, resolving problems that prevented operations like vector calls from functioning as expected. This improves the reliability and functionality of the Data Connect emulator.
Highlights
- Data Connect Emulator: The Data Connect emulator now correctly receives Application Default Credentials (ADC). This was achieved by retrieving the project's default account and passing it as an argument during the emulator's startup process.
- Code Cleanup: A debug log statement related to setting Google Application Credentials within the Data Connect emulator's initialization logic was removed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where the Data Connect emulator was not provided with Application Default Credentials (ADC). The changes involve retrieving the user's account and passing it to the emulator's configuration, which then sets up the necessary environment variables for ADC to work. The implementation is sound. I've added one comment regarding a minor code duplication that could be addressed in a follow-up to improve maintainability.
|
I think something odd is happening here. When running with With
|
|
Arghhh, disregard the previous comment. Turns out the reason why running via VS Code extension does not work is because it runs |
Description
Fixes #8819.
Scenarios Tested
Tested using the repro provided, and confirmed that we can make a vector call locally.
Sample Commands