Skip to content

Conversation

@bkendall
Copy link
Contributor

@bkendall bkendall commented Oct 2, 2025

Description

with loadedExistingBackend it was possible for two callers to receive different values since that flag was set immediately by the first caller. refactored the logic to use a promise pattern to make parallel calls more safe.

Fixes #9235

Scenarios Tested

Sample Commands

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bkendall, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of backend loading within the Firebase CLI by transitioning from a simple boolean flag to a promise-based caching system. This change is crucial for preventing race conditions and ensuring data consistency when multiple parts of the deployment process concurrently attempt to access or initialize backend configurations, particularly during complex deployments involving multiple Hosting sites and Functions.

Highlights

  • Improved Parallelism: Refactored the existingBackend loading logic to use a promise-based pattern, ensuring safer parallel calls and preventing race conditions where multiple callers might receive inconsistent values.
  • Race Condition Fix: Addressed an issue where deploying multiple Hosting sites with Functions could encounter a race condition, as noted in the changelog.
  • API Change: Replaced the loadedExistingBackend boolean flag in the Context interface with an existingBackendPromise to facilitate the new asynchronous caching mechanism.
  • Backend Loading Refactor: Modified existingBackend and loadExistingBackend functions to leverage the existingBackendPromise, ensuring that the backend is loaded only once and its result is shared across concurrent requests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses a race condition in existingBackend by replacing a boolean flag with a promise-based caching mechanism. This is a solid approach for handling concurrent initializations safely. My review includes a couple of suggestions to further improve the code's clarity and maintainability: one high-severity fix regarding the use of async which could lead to subtle bugs, and another for refactoring to improve encapsulation.

@bkendall bkendall requested review from aalej and joehan October 2, 2025 17:32
@bkendall bkendall merged commit c93a283 into master Oct 2, 2025
48 checks passed
@bkendall bkendall deleted the bk-fix-race branch October 2, 2025 18:10
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function endpoint not found when deploying multiple hosting targets

2 participants