Skip to content

Improve Chrome importer marker payload logic #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
canova wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve Chrome importer marker payload logic #5717

canova wants to merge 3 commits into from

Conversation

@canova
Copy link
Member

@canova canova commented Dec 12, 2025 •
edited
Loading

Fixes #5715.

This PR does three things:

  1. Puts the category properly to the marker categories.
  2. Removes the dummy payload if the event doesn't have any data.
  3. Removes beginEventDetail all together with all the logic around it.

It's a relatively small PR, but test changes make it look bigger.

Example chrome profile:
Trace-20251212T152428.json.zip

Before / after

It looks like the chrome categories include commas, but this way still looked like an improvement to me.

@canova canova requested a review from mstange December 12, 2025 16:44
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.66%. Comparing base (38eb6ad) to head (b1f4716).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/import/chrome.ts 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5717      +/-   ##
==========================================
+ Coverage   85.64%   85.66%   +0.01%     
==========================================
  Files         313      313              
  Lines       31013    31013              
  Branches     8449     8530      +81     
==========================================
+ Hits        26562    26566       +4     
+ Misses       4021     4017       -4     
  Partials      430      430

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstange mstange Awaiting requested review from mstange

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Chrome importer marker payload logic

1 participant

@canova