Skip to content

Rework Multi-Monitor support #4894

Description

@micw

Feature Description

Hello,

thank you, that you addressed multi-monitor support for wayland.

But as a user of both, wayland and x11, I see a huge decline in user experience with the new "select monitor" feature.

  1. It adds an extra step, so extra friction to take a screenshot
  2. It destroys the feature to create a screenshot that spans over screens
  3. It discloses the other screens. E.g. when you share one screen in a video call and make a screenshot, an overview of all screens is shown on the primary screen

I would suggest to address this in the following ways:

For X11

Just make the feature optional. The old code path should still work, allowing full-screen screenshots

For Wayland

Much more complex, unfortunately. Grabbing over all screens is already solved. The rest is not easy but IMO doable.

Flameshot would need to create one overlay for each screen and coordinate over all those. Could be possible with some kind of abstraction that represents the individual screens as one to the existing code.

One problem could be to put the overlay over all screens (short research found that it's not really standardized over different compositors. should be evaluated first, could be a show stopper).

A minor one is the input handling. Only the overlay on the active screen would receive keyboard events. Could be handled in the multi-screen abstraction and forwarded to a central place.

What do you think? I'd be willing to contribute here. I absolutely love flameshot and think it can be much better on multi-monitor (and already was in v13, but only on x11).

Best regards,
Michael.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    EnhancementFeature requests and code enhancements

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions