test: Use .Compat.i386 from freedesktop-sdk instead #495
Conversation
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
Hi, I am exploring the idea of dropping the However I haven't used bottles in a couple of years, it seems to be working on my end but I would be greatful if you could point me at common things that might break or need testing. |
087f863 to
6788d53
Compare
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. |
|
🚧 Started test build. |
com.usebottles.bottles.yml
Outdated
|
|
||
| sdk-extensions: | ||
| - org.gnome.Sdk.Compat.i386 | ||
| # - org.freedesktop.Sdk.Compat.i386 |
There was a problem hiding this comment.
While the .Extension.toolchain one works, this one fails to match the version and ends up looking for org.freedesktop.Sdk.Compat.i386//47
There was a problem hiding this comment.
This seems to be a bug in flatpak-builder. it tries to install the wrong version of the extension, but if it's already installed (24.08) it builds and runs fine.
Sorry I didn't uncomment this line. I see the error now. I think it can be resolved by adding the extension to the Sdk manifest. I'll give it a try
There was a problem hiding this comment.
This works with the following instead, but I am suspicious if it has any effect.
add-build-extensions:
org.freedesktop.Sdk.Compat.i386:
directory: lib/i386-linux-gnu
version: "24.08"
remove-after-build: true
The thing is the extension isn't needed to build at all so even less clear if it works or not, nor am I sure why we define it
There was a problem hiding this comment.
Looks like bottles is indeed not building anything for i386 anymore, last one was a78cad6
There was a problem hiding this comment.
Good news, I wasn't imagining the extgension resolution failure.
Bad news, its not working with 48 at least.
Initializing build dir
error: Requested extension org.freedesktop.Sdk.Compat.i386/x86_64/48 not installed
Error: Child process exited with code 1
~/P/com.usebottles.bottles (alatiera/fdo-i386|✔) [1]$ flatpak install org.freedesktop.Sdk.Compat.i386//24.08
Looking for matches…
Skipping: org.freedesktop.Sdk.Compat.i386/x86_64/24.08 is already installed
However I think that might be cause we only added the extension point in 49. I will test with 49beta in a bit.
https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/3899
There was a problem hiding this comment.
Yeah, it won't work with 48 unless we add the extension point. I proposed https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/3902 some time ago for this.
There was a problem hiding this comment.
This indeed works now with 49beta, cool
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
6788d53 to
bf8dc77
Compare
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
bf8dc77 to
438fd2e
Compare
|
🚧 Test build enqueued. |
|
❌ Test build was cancelled. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
|
|
||
| sdk-extensions: | ||
| - org.gnome.Sdk.Compat.i386 | ||
| - org.freedesktop.Sdk.Extension.toolchain-i386 |
There was a problem hiding this comment.
This is actually not needed at all, you can remove line range from 60 to here
438fd2e to
b0fc5d7
Compare
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. |
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
❌ Test build failed. |
6bbdbe2 to
f27df9a
Compare
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
f27df9a to
5c56e10
Compare
|
🚧 Test build enqueued. |
|
🚧 Started test build. |
|
Alright this PR served its purpose of testing the 32bit extension point if needed again, I will leave it as is. Moved the 49 changes into #506 |
|
✅ Test build succeeded. To test this build, install it from the testing repository: |
No description provided.