Skip to content

Conversation

@StanMathers
Copy link
Contributor

Testing if there is something wrong with first PR. This should work.

@StanMathers
Copy link
Contributor Author

StanMathers commented Sep 29, 2022

@FeodorFitsner You can merge this PR. As it seems, I messed up something when there was merge conflict. It was my first merge conflict in practice as a Junior. It was so confusing experience 😃

After merging, I'll delete the first one and get the docs ready.

@FeodorFitsner
Copy link
Contributor

Sounds great! Yes, docs (with a simple example) are needed for this new functionality - you could add a section with example to https://flet.dev/docs/guides/python/navigation-and-routing and describe new page props/methods here: https://flet.dev/docs/controls/page. Awaiting another PR ;)

@FeodorFitsner FeodorFitsner merged commit 97e0cdf into flet-dev:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants