Add url and url_target to controls with on_click event
#1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrr1999
pushed a commit
to zrr1999/flet
that referenced
this pull request
Jul 17, 2024
…v#1337) * All buttons have `url` and `url_target` props * `Markdown.auto_follow_links`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a solution for #1105 when Safari blocks redirects not initiated (or initiated with some delay) as a result of user gesture.
The solution allows to replace the code:
with the one that does unconditional redirect on the client (
on_clickis called anyway):New
urlandurl_targetproperties were added to these controls:ContainerElevatedButtonFilledButtonFilledTonalButtonFloatingActionButtonIconButtonListTileOutlinedButtonTextButtonTextSpanNew properties added to
Markdownto auto-follow links:auto_follow_links- default isFalse.on_tap_linkevent fires anyway.auto_follow_links_target- default is_blank- new tab/window.