chore - refactor memento tests for DI and coverage #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DI support (cwd parameter) to session.js, create-session.js, get-session.js - Add silent option to prevent process.exit() in tests - Convert parseBranchName tests to table-driven format using it.each() - Create shared test-utils/test-helpers.js (setupGitRepo, createTempDir, cleanupTempDir) - Remove all process.chdir usage from tests - Add edge case tests for uncovered branches - Reorder verify-session.js logic to eliminate unreachable fallbacks - Branch coverage: 93.1% (exceeds 92% threshold) - 184 tests passing
- Replace real git commands with jest.mock for child_process - Mock session module in create-session and get-session tests - Remove test-utils/test-helpers.js that used real git - Suppress console output in tests with jest.spyOn - Tests are now deterministic and platform-independent
- Add full fs mocking to session.test.js (existsSync, mkdirSync, readFileSync) - Add default parameter branch tests for 100% coverage in session.js - Add ZERO ATTRIBUTION blocking rules to mantra/behavior.yml and onus/git.yml - Bump mantra to 0.1.9 and onus to 0.1.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan