Add ability to dynamically search for comments#3028
Open
DavidPLamas wants to merge 2 commits intoflowable:mainfrom
Open
Add ability to dynamically search for comments#3028DavidPLamas wants to merge 2 commits intoflowable:mainfrom
DavidPLamas wants to merge 2 commits intoflowable:mainfrom
Conversation
dbmalkovsky
reviewed
Aug 25, 2021
modules/flowable-engine/src/main/java/org/flowable/engine/impl/CommentQueryImpl.java
Show resolved
Hide resolved
dbmalkovsky
reviewed
Aug 25, 2021
modules/flowable-engine/src/main/java/org/flowable/engine/impl/CommentQueryProperty.java
Show resolved
Hide resolved
dbmalkovsky
reviewed
Aug 25, 2021
modules/flowable-engine/src/main/java/org/flowable/engine/task/CommentQuery.java
Show resolved
Hide resolved
dbmalkovsky
reviewed
Aug 25, 2021
...les/flowable-engine/src/test/java/org/flowable/engine/test/api/comment/CommentQueryTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List:
I've recently encountered the need to make more complex queries for comments, more specifically I needed to be able to paginate the results through SQL queries instead of using Java due to performance reasons.
I found a way to extend Flowable's Engine in my working context and implement all those features but I felt like this should be a good contribution for the whole community so I'm making this pull request.