Skip to content

refactor: revert libbsd in favor of safe snprintf#5

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1734497720-revert-libbsd
Closed

refactor: revert libbsd in favor of safe snprintf#5
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1734497720-revert-libbsd

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Revert libbsd in favor of safe snprintf

Changes

  • Removed libbsd dependency from the project
  • Replaced unsafe sprintf calls with safe snprintf implementations
  • Added comprehensive buffer size checks and error handling
  • Maintained C11 compliance with -std=c11 flag
  • Added _XOPEN_SOURCE and _POSIX_C_SOURCE definitions for POSIX functions

Testing

  • Ran make clean && make && make test successfully
  • All tests passed without modifications
  • Ran make lint to verify code quality

Notes

  • Some clang-tidy warnings about snprintf remain but are expected for standard C functions
  • Maintained existing error handling patterns
  • Improved code maintainability by using standard C functions

Link to Devin run: https://app.devin.ai/sessions/33d674cbc128466f84ace9b92a3a4553

Co-Authored-By: michael@flox.dev <michael@flox.dev>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants