chore: improve error logging#16
Open
maximkonovalov wants to merge 2 commits into
Open
Conversation
limeytexan
previously requested changes
Apr 7, 2025
limeytexan
left a comment
Contributor
There was a problem hiding this comment.
Would be happy to merge with one small modification.
Thanks @maximkonovalov for the suggestion!
Author
Of course! Please go ahead. |
If we cannot open a log file, print its file name too. This is handy when a user skips the log filename accidently, e.g., runs t3 -- /bin/echo foo.
Accepted suggestion, rebased against upstream/main.
Contributor
|
Will rebase against #19 once that lands .. hopefully later today! Apologies for the dropping the ball for so long on this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we cannot open a log file, print its file name too. This is handy when a user skips the log filename accidently, e.g., runs t3 -- /bin/echo foo.