Exception in _handleCardChanged #2265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remonh87
reviewed
Dec 16, 2025
| try { | ||
| final map = Map<String, dynamic>.from(arguments); | ||
| final update = CardFieldInputDetails.fromJson( | ||
| Map<String, dynamic>.from(map['card']), |
Member
There was a problem hiding this comment.
I see this nesting is still necesarry tested it with latest sdk on android
Author
There was a problem hiding this comment.
the map doesn't have the 'card' value, it creates an exception and crashes.
Author
There was a problem hiding this comment.
Does the UI works for you?.
We had to fork the package in PROD as it was throwing an eception
Member
There was a problem hiding this comment.
I tested both android and ios and for the ui works. Can you give me some more details of the version of the package that you are using?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Revert card parsing logic in _handleCardChanged
This PR reverts the changes made to the input parsing logic in card_field.dart. The arguments map does not contain a nested 'card' key inside it.
Instead of incorrectly attempting to extract map['card'], this change reverts to passing the entire map directly to CardFieldInputDetails.fromJson.