Skip to content

Conversation

@csells
Copy link
Contributor

@csells csells commented Apr 27, 2025

Replaces the attachments UI from moving the text input box aside to popping up a menu instead:

before

image

after

image

Also fixes text field vertical centering issue under Cupertino:

before

image

after

image

issues fixed by this PR

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@csells csells requested a review from domesticmouse April 27, 2025 18:48
vertical: 8,
),
),
: ChatTextField(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indent level here tells me this could probably do with some refactoring to pull out new named widgets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. ptal.

@csells csells merged commit c90b6d9 into flutter:main Apr 27, 2025
3 checks passed
@csells csells deleted the add-file-popup branch May 14, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants