[impeller] Use the GLES3 shaders in the embedder if supported #180072
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the embedder to use GLES3 shaders when supported by the driver. The logic for creating shader mappings has been refactored into a new helper function GetShaderMappings. My review identified a critical issue in this new function where the logic for selecting between GLES2 and GLES3 shaders is inverted, which would lead to loading the incorrect shader set. I've provided a code suggestion to correct this logic.
engine/src/flutter/shell/platform/embedder/embedder_surface_gl_impeller.cc
Show resolved
Hide resolved
753394a to
db49ef4
Compare
Adds the GLES3 shaders to the embedder (used by Linux and custom embedders) if they are supported.
Fixes #179185
Pre-launch Checklist
///).