Expose the Scroll Controller of a scrollable TabBar #180120
Open
+586
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huycozy <huy@nevercode.io>
Signed-off-by: huycozy <huy@nevercode.io> Signed-off-by: huycozy <huy@nevercode.io>
ffd0833 to
b99463f
Compare
| @@ -2016,6 +2054,13 @@ class _TabBarState extends State<TabBar> { | |||
| ).add(widget.padding ?? EdgeInsets.zero) | |||
| : widget.padding; | |||
| _scrollController ??= _TabBarScrollController(this); | |||
Contributor
There was a problem hiding this comment.
Why don't we make _TabBarScrollController public but final?
I understand that the private _TabBarState needs to stay private, but why don't we include a private setter for it?
final class TabBarScrollController extends ScrollController {
/// The state of the attached [TabBar], if any.
///
/// Is null when not attached to a [TabBar].
_TabBarState? _tabBarState;
void _attachToTabBar(_TabBarState tabBar) {
_tabBarState = tabBar;
}
@override
ScrollPosition createScrollPosition(
ScrollPhysics physics,
ScrollContext context,
ScrollPosition? oldPosition,
) {
return _TabBarScrollPosition(
physics: physics,
context: context,
oldPosition: oldPosition,
tabBar: _tabBarState!,
);
}
}Then we only need to call the attach method using a private helper method? (which handles creating an internal controller and attaches the this)
For example:
TabBarScrollController _setUpTabBarController() {
final tabBarController = widget.tabBarController ?? TabBarScrollController();
tabBarController._attachToTabBar(this);
return tabBarController;
}
// ...
_scrollController ??= _setUpTabBarController()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scrollbar's ScrollController has no ScrollPosition attached.#124608onScrollControllerCreatedthat exposesScrollControllerfor users to use.onScrollControllerCreated, 1 for regression test for Wrapping a Scrollbar around a TabBar throws errorThe Scrollbar's ScrollController has no ScrollPosition attached.#124608)onScrollControllerCreated, 1 for Scrollbar integration) and tests for themDemo
after.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.