Skip to content

Update NavigationRail to support Material 3 tokens #99171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2022
Merged

Update NavigationRail to support Material 3 tokens #99171

merged 4 commits into from
Mar 10, 2022

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Feb 25, 2022 •
edited
Loading

Part of: #91605

Updated NavigationRail widget to support Material Design 3 tokens.

NavRail-M3

In order to not break anyone currently using this widget, the new support is gated by ThemeData.useMaterial3 flag. To use the NavigationRail with the Material 3 token defaults, turn on the useMaterial3 flag in the ThemeData:

  return MaterialApp(
    theme: ThemeData(useMaterial3: true),
    // ...
  );

This also adds new minWidth and minExtendedWidth parameters to the NavigationRailThemeData.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 25, 2022
@darrenaustin darrenaustin changed the title Migrate NavigationRail to Material 3 Migrate NavigationRail to Material 3. Feb 28, 2022
@darrenaustin darrenaustin marked this pull request as ready for review March 3, 2022 00:21
guidezpl
guidezpl reviewed Mar 3, 2022
View reviewed changes
packages/flutter/lib/src/material/navigation_rail.dart Outdated
Copy link
Member

@guidezpl guidezpl Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be tokens available for these colors and shapes

guidezpl
guidezpl approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@darrenaustin darrenaustin mentioned this pull request Mar 8, 2022
Closed
guidezpl
guidezpl reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to add a sample with useMaterial3 enabled

@darrenaustin darrenaustin merged commit 57aa490 into flutter:master Mar 10, 2022
@darrenaustin darrenaustin deleted the m3_navigation_rail branch March 10, 2022 00:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
f612791
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
672b4fd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
f0be029
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
23100ef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
ff5084b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
b0a936f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
b2005ce
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
97a62ce
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
1f142cf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
06c0d5b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
7900a17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
a4b41c7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
51e9e75
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
d009cf5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
f594168
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
e53698e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
c87c9b3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
100c307
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
57aa490 Migrate NavigationRail to Material 3. (flutter/flutter#99171)
9ed9f19
@darrenaustin darrenaustin mentioned this pull request Mar 17, 2022
Closed
70 tasks
@guidezpl guidezpl changed the title Migrate NavigationRail to Material 3. Update NavigationRail to support Material 3 tokens Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

@clocksmith clocksmith clocksmith approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darrenaustin @clocksmith @guidezpl