Skip to content

Add Android lifecycles test #99319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2022
Merged

Add Android lifecycles test #99319

merged 3 commits into from
Mar 1, 2022

Conversation

@blasten
Copy link

@blasten blasten commented Mar 1, 2022

Add Android lifecycle test, and minor clean up to android_choreographer_do_frame_test.dart
for consistency.

Tests: Activity#onStop(), Activity#onResume(), Activity#onPause()
from Dart perspective in debug, profile, and release modes.

Issue: #97853

blasten
blasten commented Mar 1, 2022
View reviewed changes
dev/devicelab/lib/tasks/android_choreographer_do_frame_test.dart
// This test ensures that Choreographer#doFrame finishes during application startup.
// This test fails if the application hangs during this period.
// https://ui.perfetto.dev/#!/?s=da6628c3a92456ae8fa3f345d0186e781da77e90fc8a64d073e9fee11d1e65
/// Tests that Choreographer#doFrame finishes during application startup.
Copy link
Author

@blasten blasten Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all a clean up. It should probably be in a different PR :/

@blasten blasten marked this pull request as ready for review March 1, 2022 05:06
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 1, 2022
keyonghan
keyonghan reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.ci.yaml and TESTOWNERS LGTM.

@fluttergithubbot fluttergithubbot merged commit 6c818d7 into flutter:master Mar 1, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
8d9f8f0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
494b971
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
0fc11d0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
4fd1a09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
827445d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
1fdf520
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
f847e76
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
45d40b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
20079b0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
0b6d470
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
4217274
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
a7303f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
6cdab09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
e43ee55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
9220c76
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
a1e8720
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
35753ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
9fd3541
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
5c6d76e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
58453a6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
1d80228
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
c188462
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
887da19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
878aa5c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
0671395
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
1e462b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
36157cb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
98cb0d4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
1495e43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
d36a879
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
a1fa604
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
f10d407
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
4263de9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
580acc1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
2828d24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
a65e460
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6c818d7 Add Android lifecycles test (flutter/flutter#99319)
e30eb22
@jmagman jmagman mentioned this pull request May 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

+1 more reviewer

@keyonghan keyonghan keyonghan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blasten @jason-simmons @keyonghan @fluttergithubbot