Remove tool crash git.io link shortener #99574

jmagman · 2022-03-04T23:42:58Z

git.io link shortener is dead, service responding 422. GitHub has removed the service as of January 2022.

Remove the code that posts a request to have the link shortened.

Fixes #53140
See also #99572

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-03-04T23:46:20Z

packages/flutter_tools/test/src/fake_http_client.dart

-///
-/// This should only be used when the http client cannot be set directly, such as
-/// when testing `package:http` code.
-Future<void> overrideHttpClients(Future<void> Function() callback,  FakeHttpClient httpClient) async {


Found dead code.

christopherfujino

RIP git.io

Jasguerrero

LGTM

jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2022

jmagman self-assigned this Mar 4, 2022

flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Mar 4, 2022

jmagman force-pushed the remove-shortener branch from 4ed7b53 to e3be2bf Compare March 4, 2022 23:44

Remove tool crash git.io link shortener

ef5d21c

jmagman force-pushed the remove-shortener branch from e3be2bf to ef5d21c Compare March 4, 2022 23:44

jmagman commented Mar 4, 2022

View reviewed changes

jmagman requested review from Jasguerrero and christopherfujino March 8, 2022 22:16

christopherfujino approved these changes Mar 8, 2022

View reviewed changes

Jasguerrero approved these changes Mar 8, 2022

View reviewed changes

jmagman added the waiting for tree to go green label Mar 8, 2022

fluttergithubbot merged commit dd97133 into flutter:master Mar 9, 2022

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to dd97133df249 (106 revisions) flutter/packages#1135

Closed

jmagman deleted the remove-shortener branch March 9, 2022 01:03

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

d4068e0

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to a7c85996b8ad (107 revisions) flutter/packages#1136

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

c57a3d6

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 3172065fbab0 (108 revisions) flutter/packages#1137

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

20090cb

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from c8538873c80e to 3172065fbab0 (3 revisions) flutter/plugins#5022

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

47c016a

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 3172065fbab0 (108 revisions) flutter/packages#1138

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

932ab5b

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 3172065fbab0 (108 revisions) flutter/packages#1139

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

3b26a06

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to 5f76ac35bcd3 (109 revisions) flutter/packages#1140

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

87063df

engine-flutter-autoroll mentioned this pull request Mar 9, 2022

Roll Flutter from 38dbbb17f8ce to bf6fcee17345 (110 revisions) flutter/packages#1141

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

547e1a3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

167667b

engine-flutter-autoroll mentioned this pull request Mar 14, 2022

Roll Flutter from 38dbbb17f8ce to 4f4c7816c337 (148 revisions) flutter/packages#1193

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

9d25f49

engine-flutter-autoroll mentioned this pull request Mar 14, 2022

Roll Flutter from 38dbbb17f8ce to 4f4c7816c337 (148 revisions) flutter/packages#1194

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

bf89314

engine-flutter-autoroll mentioned this pull request Mar 14, 2022

Roll Flutter from 38dbbb17f8ce to 4f4c7816c337 (148 revisions) flutter/packages#1195

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

793a76e

engine-flutter-autoroll mentioned this pull request Mar 14, 2022

Roll Flutter from 38dbbb17f8ce to 11deb156c29d (149 revisions) flutter/packages#1196

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

be041ff

engine-flutter-autoroll mentioned this pull request Mar 14, 2022

Roll Flutter from 38dbbb17f8ce to 11deb156c29d (149 revisions) flutter/packages#1197

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

b5c4751

engine-flutter-autoroll mentioned this pull request Mar 14, 2022

Roll Flutter from 38dbbb17f8ce to f2646b1589ad (150 revisions) flutter/packages#1198

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

e42a1a1

engine-flutter-autoroll mentioned this pull request Mar 14, 2022

Roll Flutter from 38dbbb17f8ce to cd725e364045 (151 revisions) flutter/packages#1199

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

fb08860

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

bc4b964

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

f84ee64

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

28bdc8e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

c6fceb7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

ffc550c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

d0b9e48

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

3e023d1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

05948de

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

cf3cbb6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

bea0c49

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

cc5b83a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

92cb761

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

00eff16

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022

dd97133 Remove tool crash git.io link shortener (flutter/flutter#99574)

81820cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove tool crash git.io link shortener #99574

Remove tool crash git.io link shortener #99574

Uh oh!

jmagman commented Mar 4, 2022

Uh oh!

jmagman Mar 4, 2022

Uh oh!

christopherfujino Mar 8, 2022

Uh oh!

christopherfujino left a comment

Uh oh!

Jasguerrero left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove tool crash git.io link shortener #99574

Remove tool crash git.io link shortener #99574

Uh oh!

Conversation

jmagman commented Mar 4, 2022

Pre-launch Checklist

Uh oh!

jmagman Mar 4, 2022

Choose a reason for hiding this comment

Uh oh!

christopherfujino Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Jasguerrero left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants