Skip to content

Conversation

@clocksmith
Copy link
Contributor

@clocksmith clocksmith commented Mar 8, 2022

Android Samples

black
pink
green

Tests

  • There are 3 paint check tests for the InkSparkle splashFactory.
  1. ElevatedButton (bounded)
  2. InkWell (bounded)
  3. InkResponse (unbounded)
  • There are 18 golden tests to verify the consistency of the sparkle.
    • These tests use a deterministic version of the splashFactory, which is identical to the default splashFactory, except that it does not use Random to seed the turbulence effect.
    • 3 button click positions are tested: top left, center, bottom right.
    • 6 frames are captured for each animation.

Note on performance

Currently, the shader needs to be compiled at run time before the first InkSparkle can be painted. This takes 3-4 milliseconds on a Pixel 6 Pro and 30-35 milliseconds on a 2014 Moto E. The Moto E runs InkRipple at about 5 fps and the InkSparkle at about 5 fps. Even in the worst case, the async shader compilation is negligible, but it could be moved to MaterialApp or Theme creation instead.

Up next

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 8, 2022
@clocksmith clocksmith added the a: animation Animation APIs label Mar 8, 2022
@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/99731

@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 6.
View them at https://flutter-gold.skia.org/cl/github/99731

@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/99731

@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 8.
View them at https://flutter-gold.skia.org/cl/github/99731

@skia-gold
Copy link

Gold has detected about 20 new digest(s) on patchset 9.
View them at https://flutter-gold.skia.org/cl/github/99731

@skia-gold
Copy link

Gold has detected about 15 new digest(s) on patchset 10.
View them at https://flutter-gold.skia.org/cl/github/99731

@skia-gold
Copy link

Gold has detected about 7 new digest(s) on patchset 11.
View them at https://flutter-gold.skia.org/cl/github/99731

@skia-gold
Copy link

Gold has detected about 12 new digest(s) on patchset 12.
View them at https://flutter-gold.skia.org/cl/github/99731

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: animation Animation APIs f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce new Android 12 style ink ripple

6 participants