Skip to content

[tools] Fix OOB test error #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2023
Merged

[tools] Fix OOB test error #4144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40507c0
[tools] Fix OOB test error
stuartmorgan-g Jun 5, 2023
1b5982c
Fix tests that had blank changelogs
stuartmorgan-g Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions script/tool/test/update_min_sdk_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ void main() {
});

test('fails if --flutter-min is missing', () async {
Exception? commandError;
Error? commandError;
await runCapturingPrint(runner, <String>[
'update-min-sdk',
], exceptionHandler: (Exception e) {
], errorHandler: (Error e) {
commandError = e;
});

expect(commandError, isA<UsageException>());
expect(commandError, isA<ArgumentError>());
});

test('updates Dart when only Dart is present', () async {
Expand Down
16 changes: 8 additions & 8 deletions script/tool/test/update_release_info_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ void main() {

group('flags', () {
test('fails if --changelog is missing', () async {
Exception? commandError;
Error? commandError;
await runCapturingPrint(runner, <String>[
'update-release-info',
'--version=next',
], exceptionHandler: (Exception e) {
], errorHandler: (Error e) {
commandError = e;
});

expect(commandError, isA<UsageException>());
expect(commandError, isA<ArgumentError>());
});

test('fails if --changelog is blank', () async {
Expand All @@ -76,14 +76,14 @@ void main() {
});

test('fails if --version is missing', () async {
Exception? commandError;
Error? commandError;
await runCapturingPrint(
runner, <String>['update-release-info', '--changelog', ''],
exceptionHandler: (Exception e) {
runner, <String>['update-release-info', '--changelog', 'A change.'],
errorHandler: (Error e) {
commandError = e;
});

expect(commandError, isA<UsageException>());
expect(commandError, isA<ArgumentError>());
});

test('fails if --version is an unknown value', () async {
Expand All @@ -92,7 +92,7 @@ void main() {
'update-release-info',
'--version=foo',
'--changelog',
'',
'A change.',
], exceptionHandler: (Exception e) {
commandError = e;
});
Expand Down