Replace pyannote with Silero VAD for voice activity detection #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the VAD implementation by replacing pyannote.audio with Silero VAD, which offers several benefits: - No HuggingFace authentication required - Lighter weight and fewer dependencies - Simpler API and easier to use - Maintained function signature compatibility Changes: - Rewrote src/vui/vad.py to use Silero VAD instead of pyannote - Removed pyannote.audio dependency from pyproject.toml - Updated readme.md to remove pyannote authentication instructions - Added merge_segments helper function for post-processing
Improvements: - Fixed double loading of Silero VAD model - Store both model and utils in pipeline for efficiency - Added comprehensive test suite for validation - Improved code documentation Test files added: - test_vad.py: Full integration test with synthetic audio - test_vad_code_review.py: Code structure validation - test_vad_simple.py: Module structure test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the VAD implementation by replacing pyannote.audio
with Silero VAD, which offers several benefits:
Changes: