Skip to content

Remove unused replace directives and have boilerplate use local flytestdlib #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sovietaced merged 2 commits into from
Dec 4, 2025
Merged

Remove unused replace directives and have boilerplate use local flytestdlib #6785

Sovietaced merged 2 commits into from
Dec 4, 2025

Conversation

@Sovietaced
Copy link
Member

@Sovietaced Sovietaced commented Dec 3, 2025 •
edited by flyte-bot
Loading

Why are the changes needed?

There are a number of unused replace directives which show warnings in my editor. This should simplify the go mods.

What changes were proposed in this pull request?

Remove unused replace directives.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Summary by Bito

  • Removes unused replace directives from the Go module files, which were causing warnings in the editor.
  • Updates several dependencies to their latest versions, ensuring the project uses the most current libraries.
  • Simplifies the go.mod file, enhancing maintainability and contributing to a cleaner project structure.
  • Overall, the changes touch on Go module configurations and dependencies, simplifying the module management and improving project maintainability.

@Sovietaced
Remove unused replace directives and have boilerplate use local flyte…
dbeaddc 
…stdlib

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@Sovietaced Sovietaced added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Dec 3, 2025
@flyte-bot
Copy link
Collaborator

flyte-bot commented Dec 3, 2025

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at eduardo@union.ai.

@codecov
Copy link

codecov bot commented Dec 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.90%. Comparing base (55568e0) to head (3d417fc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6785      +/-   ##
==========================================
- Coverage   56.91%   56.90%   -0.01%     
==========================================
  Files         929      929              
  Lines       58081    58081              
==========================================
- Hits        33055    33050       -5     
- Misses      21985    21990       +5     
  Partials     3041     3041
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 52.98% <ø> (-0.04%) ⬇️
unittests-flytecopilot 43.16% <ø> (ø)
unittests-flytectl 64.02% <ø> (ø)
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.14% <ø> (ø)
unittests-flytepropeller 53.54% <ø> (ø)
unittests-flytestdlib 63.29% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sovietaced Sovietaced marked this pull request as ready for review December 3, 2025 20:16
@flyte-bot
Copy link
Collaborator

flyte-bot commented Dec 4, 2025

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

machichima
machichima approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@machichima machichima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Sovietaced Sovietaced merged commit d6ed32a into flyteorg:master Dec 4, 2025
48 of 49 checks passed
@Sovietaced Sovietaced deleted the cleanup-gomods branch December 4, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@machichima machichima machichima approved these changes

Assignees

No one assigned

Labels

housekeeping Issues that help maintain flyte and keep it tech-debt free

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sovietaced @flyte-bot @machichima