Fix #4186: Change failOnMissingLocations from primitive boolean to Bo…#4196
Open
eunseo9311 wants to merge 1 commit into
Open
Fix #4186: Change failOnMissingLocations from primitive boolean to Bo…#4196eunseo9311 wants to merge 1 commit into
eunseo9311 wants to merge 1 commit into
Conversation
… to Boolean wrapper The failOnMissingLocations field in AbstractFlywayTask was declared as a primitive boolean, which always defaults to false and can never be null. This caused putIfSet() to always use the default value instead of the user-configured value from FlywayExtension. Changed the field type from 'boolean' to 'Boolean' to match the pattern used by all other boolean configuration fields in this class (19 fields use Boolean wrapper, only this one was primitive). This is the same bug pattern as flyway#3940 (connectRetries/connectRetriesInterval).
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Fix #4186: Change failOnMissingLocations from primitive boolean to Boolean wrapper in Gradle plugin
Body:
Summary
failOnMissingLocationsconfiguration being ignored in Gradle pluginbooleantoBooleanwrapper classProblem
The
failOnMissingLocationsfield inAbstractFlywayTaskwas declared as primitiveboolean, which:falseand can never benullputIfSet()to always use the default value instead of user-configured valuefailOnMissingLocations = trueineffectiveSolution
Changed
public boolean failOnMissingLocationstopublic Boolean failOnMissingLocationsto match the pattern used by all other 19 boolean configuration fields in this class.Related Issues
Test plan
mvn compile)failOnMissingLocations = truein Gradle and verify it takes effect