Skip to content

Suppress Clang's warning on zero as a null pointer #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitaut merged 1 commit into from
Sep 17, 2017
Merged

Suppress Clang's warning on zero as a null pointer #567

vitaut merged 1 commit into from
Sep 17, 2017

Conversation

@feroldi
Copy link
Contributor

@feroldi feroldi commented Sep 16, 2017

This suppresses the Clang warning -Wzero-as-null-pointer-constant by using FMT_NULL instead of 0:

fmt/format.cc:124:24: error: zero as null pointer
                      constant [-Werror,-Wzero-as-null-pointer-constant]
  FMT_ASSERT(buffer != 0 && buffer_size != 0, "invalid buffer");
                       ^
                       nullptr

@feroldi
Copy link
Contributor Author

feroldi commented Sep 17, 2017

It seems there's an error with npm dependencies on Travis environment?

-npm WARN engine less@2.7.2: wanted: {"node":">=0.12"} (current: {"node":"0.10.48","npm":"2.15.1"})

@vitaut vitaut merged commit 5de459b into fmtlib:master Sep 17, 2017
@vitaut
Copy link
Contributor

vitaut commented Sep 17, 2017

Merged, thanks!

Something is messed up with npm dependencies, I'll try to install an older version of less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feroldi @vitaut