Fix build on OpenBSD #660
Merged
Fix build on OpenBSD #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBSD doesn't have strtod_l() (at least under the default headers), so the class Locale that the macro gates won't compile.
Contributor
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD lacks
strtod_l, so theLocaleclass won't compile. Looking around, this problem has apparently occurred in other environments as well (#388, #345), so I fixed it the same way they were fixed: by appending&& !defined(__OpenBSD__)to the preprocessor condition gating the definition of theFMT_LOCALEmacro.