Skip to content

Conversation

@drrlvn
Copy link
Contributor

@drrlvn drrlvn commented Jun 5, 2018

No description provided.

@Remotion
Copy link
Contributor

Remotion commented Jun 6, 2018

It would be consistent to move is_tuple_like<> to fmt namespace too.

@drrlvn
Copy link
Contributor Author

drrlvn commented Jun 6, 2018

@Remotion what about is_like_std_string, should I move that to fmt as well?

@drrlvn
Copy link
Contributor Author

drrlvn commented Jun 6, 2018

Moved is_tuple_like as well.

@Remotion
Copy link
Contributor

Remotion commented Jun 6, 2018

Then may be it was not great idea to do this in this PR as well ?
#763

what about is_like_std_string, should I move that to fmt as well?

I think yes.

@drrlvn
Copy link
Contributor Author

drrlvn commented Jun 6, 2018

I think yes.

Actually looking at it again it looks to only be used in is_range so I don't see much value in moving is_like_std_string as well.

@vitaut vitaut merged commit cd5b567 into fmtlib:master Jun 6, 2018
@vitaut
Copy link
Contributor

vitaut commented Jun 6, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants