Fix conversion and other pedantic warnings #983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2018
Closed
Closed
Contributor
Author
|
With 8ea3c13, if we enable sign-conversion warnings as part of the FMT_PEDANTIC flag set then we don't get any more warnings in the headers. There are however several conversion warnings in the test code - but it is heavily templated so I'm not sure how to fix them. |
8ea3c13 to
e4edc84
Compare
vitaut
requested changes
Dec 19, 2018
Contributor
vitaut
left a comment
There was a problem hiding this comment.
Looks great, just some minor comments inline. Thanks for working on this!
| protected: | ||
| // Don't initialize ptr_ since it is not accessed to save a few cycles. | ||
| basic_buffer(std::size_t sz) FMT_NOEXCEPT: size_(sz), capacity_(sz) {} | ||
| basic_buffer(std::size_t sz) FMT_NOEXCEPT: ptr_(FMT_NULL), size_(sz), capacity_(sz) {} |
Contributor
There was a problem hiding this comment.
ptr_ is not initialized intentionally here. This has measurable performance impact on some benchmarks.
Contributor
Author
There was a problem hiding this comment.
OK - as long as the header does not produce warnings when included in user-level code.
Merged
Contributor
Author
|
Superseded by #989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #981 and #982 . Rebased onto current master.