Distinguish float type formatting from double #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support more than the current 16 types.
a316e3d to
a0068d7
Compare
vitaut
reviewed
Oct 12, 2019
Contributor
vitaut
left a comment
There was a problem hiding this comment.
Looks great, thanks! Just one minor comment.
include/fmt/format-inl.h
Outdated
| char* sprintf_format<float>(float value, internal::buffer<char>& buf, | ||
| sprintf_specs specs) { | ||
| // printf does not have a float format modifier, it only supports double. | ||
| return sprintf_format(double(value), buf, specs); |
Contributor
There was a problem hiding this comment.
I suggest replacing this with
return sprintf_format<double>(value, buf, specs);
to avoid cast.
It handles all floating point types, not just doubles.
Contributor
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1353 and is the first half of the fix for #1336.
I suggest reviewing commits one by one.