Skip to content

Conversation

@DevO2012
Copy link

fixed std::min and std::max problem because of min and max macros in win...

@vitaut
Copy link
Contributor

vitaut commented Apr 27, 2015

Thanks for the PR. windows.h is a quite a mess, but I don't think that C++ Format should unconditionally define global macros that can affect it. The reason is that such macros can break other library's or user code when windows.h is included elsewhere. I think it should be up to the user to decide whether these macros are defined or not and they can be defined before including format.h or on a project level.

@vitaut vitaut closed this Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants