Skip to content

Add ability to join elements of std::initializer_list #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitaut merged 1 commit into from
Mar 15, 2020
Merged

Add ability to join elements of std::initializer_list #1591

vitaut merged 1 commit into from
Mar 15, 2020

Conversation

@Rapotkinnik
Copy link

@Rapotkinnik Rapotkinnik commented Mar 13, 2020

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

@vitaut
Copy link
Contributor

vitaut commented Mar 13, 2020

Thanks for the PR. Mostly looks good but please move this to fmt/ranges.h and apply clang-format to your changes.

@Rapotkinnik
Copy link
Author

Rapotkinnik commented Mar 15, 2020 •
edited
Loading

Sorry, but is it ok...

$ ./bin/Debug/ranges-test.exe
[==========] Running 0 tests from 0 test cases.
[==========] 0 tests from 0 test cases ran. (0 ms total)
[  PASSED  ] 0 tests.

...or I ran a wrong test?

@Rapotkinnik Rapotkinnik force-pushed the feature/join-initializer-list branch from 5497413 to 1beef90 Compare March 15, 2020 11:26
@Rapotkinnik Rapotkinnik force-pushed the feature/join-initializer-list branch from 1beef90 to 5edd2ce Compare March 15, 2020 12:00
@vitaut vitaut merged commit 85050aa into fmtlib:master Mar 15, 2020
@vitaut
Copy link
Contributor

vitaut commented Mar 15, 2020

ranges-test require C++14:

fmt/test/ranges-test.cc

Line 17 in 85050aa

#if (__cplusplus > 201402L) || \
. You could move the JoinInitializerList test outside of the ifdef block but that's not critical.

@Rapotkinnik
Copy link
Author

Rapotkinnik commented Mar 16, 2020 •
edited
Loading

201402L

I built library this way cmake . -DCMAKE_CXX_STANDARD=14 and nothing changed...what was I doing wrong?=)

@vitaut
Copy link
Contributor

vitaut commented Mar 16, 2020

My bad, it's > not >= in __cplusplus > 201402L, so it requires C++17.

@Rapotkinnik
Copy link
Author

Rapotkinnik commented Mar 17, 2020

But when I did cmake . -DCMAKE_CXX_STANDARD=17
I got E:\Workspace\fmt\test\gtest\gtest.h(9692): error C2039: 'tr1': is not a member of 'std' [E:\Workspace\fmt\test\gmock.vc xproj]...

Is it a bug?

@vitaut
Copy link
Contributor

vitaut commented Mar 17, 2020

Looks like a gtest bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rapotkinnik @vitaut