Fix Mingw support #1693
Closed
Fix Mingw support #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If _POSIX_ is set, mingw will no longer prefix *some* function names with an underscore, which is expected by libfmt. Rather than handling them case by case, we'll just avoid the POSIX macros. Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Contributor
|
Thanks for the PR but these should be fixed in source Lines 50 to 60 in 297c3b2 not in CMake. |
Contributor
Author
|
Right, Thanks for the quick feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If POSIX is set, mingw will no longer prefix some function names
with an underscore, which is expected by libfmt. Rather than handling
them case by case, we'll just avoid the POSIX macros.
Signed-off-by: Lucian Petrut lpetrut@cloudbasesolutions.com
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.