fix compiler warnings in public header files #1856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core.h: buffer had virtual functions but the dtor was not virtual. format.f: fix two sign conversions warnings
vitaut
requested changes
Sep 3, 2020
| capacity_(cap) {} | ||
|
|
||
| ~buffer() = default; | ||
| virtual ~buffer() = default; |
Author
There was a problem hiding this comment.
Is the idea behind that to keep the vtable as small as possible? If that's the case maybe by using CRTP we could get rid of the vtable at all and satisfy my compiler ;)
Contributor
There was a problem hiding this comment.
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-dtor-virtual. CRTP is not needed here, I suggest suppressing the useless warning.
| // "false" for bool. | ||
| constexpr int max_size = detail::digits10<T>() + 2; | ||
| char buffer[max_size > 5 ? max_size : 5]; | ||
| char buffer[max_size > 5 ? static_cast<size_t>(max_size) : 5]; |
Contributor
|
Partially merged in 45da432. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.h: buffer had virtual functions but the dtor was not virtual.
format.f: fix two sign conversions warnings
This warnings occurred on clang and gcc with -Wsign-conversion and -Wnon-virtual-dtor.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.