Remove fallback to inline specifier from FMT_CONSTEXPR(20) macro #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e9a21f to
70ae54a
Compare
…e` specifiers in headers
…e` specifiers in tests
70ae54a to
f5e9b86
Compare
vitaut
requested changes
Dec 29, 2020
Contributor
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR. Mostly looks good, just a few minor comments inline =).
| template <> FMT_CONSTEXPR const char* get_units<std::peta>() { return "Ps"; } | ||
| template <> FMT_CONSTEXPR const char* get_units<std::exa>() { return "Es"; } | ||
| template <> FMT_CONSTEXPR const char* get_units<std::ratio<60>>() { | ||
| template <> FMT_CONSTEXPR inline const char* get_units<std::atto>() { |
Contributor
There was a problem hiding this comment.
Can we remove inline from all these functions? Ideally all of this should be rewritten without template specializations but this is out of scope of the current PR.
Contributor
Author
There was a problem hiding this comment.
It causes multiple definitions of these functions.
Maybe a test for multiple definitions can be added, which would include all headers in two object files and link them together. Because now I have to include chrono.h into util.h in the test directory to get this error.
Contributor
There was a problem hiding this comment.
Makes sense. I don't think the multiple definition test is necessary.
…d `inline` specifiers" This reverts commit f35325e
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was discussed here - #2056 (comment), an fallback to the
inlineinsideFMT_CONSTEXPR(20)macro definitions is not always a good solution. Especially whenFMT_CONSTEXPR(20)macro should be used together withFMT_INLINEmacro, in C++11 they both expand toinlinespecifier.In this PR I removed that fallback to
inlineand placedinlinespecifiers where it's needed (for non-template, not member or friend defined in class/struct/union functions), so everything should stay the same in C++11. WhenFMT_CONSTEXPR(20)is expanded toconstexprall these manually-tuned functions will haveconstexpr inlinespecifiers, which is okay.