MS Visual Studio "/Zc:wchar_t-" compiler parameter support added #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
added a commit
that referenced
this pull request
Oct 25, 2015
MS Visual Studio "/Zc:wchar_t-" compiler parameter support added
Contributor
|
Merged with a minor change in acfa858 (without this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
/Zc:wchar_t-compiler parameter is specified, thenwchar_tis defined astypedef unsigned short wchar_t;Thus, this leads to conflict in template definition in
format.hYou can verify it in any Visual Studio project with spdlog with
reference: https://msdn.microsoft.com/ru-ru/library/dh8che7s.aspx