Skip to content

Fix static_assert feature detection on clang #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitaut merged 1 commit into from
Nov 12, 2015
Merged

Fix static_assert feature detection on clang #228

vitaut merged 1 commit into from
Nov 12, 2015

Conversation

@dean0x7d
Copy link
Contributor

@dean0x7d dean0x7d commented Nov 12, 2015

I had an unused typedef warning as shown below. Looks like static_assert couldn't be found on clang
This PR fixes it.

cppformat/posix.cc:162:3: warning: unused typedef 'Assert163'
      [-Wunused-local-typedef]
  FMT_STATIC_ASSERT(sizeof(fmt::LongLong) >= sizeof(file_stat.st_size),
  ^

vitaut added a commit that referenced this pull request Nov 12, 2015
@vitaut
Merge pull request #228 from dean0x7d/fix_warning
3df9bf3 
Fix static_assert feature detection on clang
@vitaut vitaut merged commit 3df9bf3 into fmtlib:master Nov 12, 2015
@vitaut
Copy link
Contributor

vitaut commented Nov 12, 2015

Thanks!

@dean0x7d dean0x7d deleted the fix_warning branch November 12, 2015 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dean0x7d @vitaut